diff --git a/copienator_gui/giving_names.py b/copienator_gui/giving_names.py index 95219bf..c328879 100644 --- a/copienator_gui/giving_names.py +++ b/copienator_gui/giving_names.py @@ -44,7 +44,7 @@ def find_name_issues(evaluation: Path) -> list[NameIssue]: reasons = [] if name.casefold() == "unknown": reasons.append("nom inconnu") - if counts[name.casefold()] > 1: + elif counts[name.casefold()] > 1: reasons.append(f"nom attribué à {counts[name.casefold()]} copies") if reasons: issues.append(NameIssue(folder, name, copy_id, tuple(reasons))) diff --git a/tests/test_gui_core.py b/tests/test_gui_core.py index b698628..5e4cdd5 100644 --- a/tests/test_gui_core.py +++ b/tests/test_gui_core.py @@ -2428,6 +2428,7 @@ class WorkflowTests(unittest.TestCase): "Dupont (02)": (b"two-jpg", b"two-pdf"), "Dupont (03)": (b"three-jpg", b"three-pdf"), "Unique (04)": (b"four-jpg", b"four-pdf"), + "unknown (05)": (b"five-jpg", b"five-pdf"), } for folder_name, (jpg, pdf) in folders.items(): folder = return_dir / folder_name @@ -2439,7 +2440,11 @@ class WorkflowTests(unittest.TestCase): (folder / "answers").mkdir() issues = find_name_issues(evaluation) - self.assertEqual([issue.copy_id for issue in issues], ["01", "02", "03"]) + self.assertEqual([issue.copy_id for issue in issues], ["01", "02", "03", "05"]) + self.assertEqual(issues[0].reasons, ("nom inconnu",)) + self.assertEqual(issues[3].reasons, ("nom inconnu",)) + self.assertEqual(issues[1].reasons, ("nom attribué à 2 copies",)) + self.assertEqual(issues[2].reasons, ("nom attribué à 2 copies",)) self.assertEqual( original_copy_path(evaluation, "01"), original_dir / "Copie01.pdf", @@ -2453,7 +2458,7 @@ class WorkflowTests(unittest.TestCase): self.assertTrue((renamed / "answers").is_dir()) self.assertEqual( [issue.copy_id for issue in find_name_issues(evaluation)], - ["02", "03"], + ["02", "03", "05"], ) def test_export_and_import_defaults_follow_previous_runs(self) -> None: